gh-118518: Use the raw syscall directly for gettid #118592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pablogsal
commented
May 5, 2024
•
pablogsal
commented
- Issue: Allow perf to work without frame pointers #118518
|
!buildbot AMD64 RHEL8 |
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a08d6b4 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
| @@ -575,7 +576,7 @@ static void perf_map_jit_write_entry(void *state, const void *code_addr, | |||
| ev.base.size = sizeof(ev) + (name_length+1) + size; | |||
| ev.base.time_stamp = get_current_monotonic_ticks(); | |||
| ev.process_id = getpid(); | |||
| ev.thread_id = gettid(); | |||
| ev.thread_id = syscall(SYS_gettid); | |||
There was a problem hiding this comment.
Perhaps it would make sense to leverage the existing thread API, e.g. PyThread_get_thread_native_id()?
There was a problem hiding this comment.
I did that first but that has a check first for !initialized that calls PyThread_init_thread and that was causing problems when fork happens.
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.