Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117953: Imply Single-phase Init if the Init Function Fails #118684

Merged
merged 1 commit into from
May 7, 2024
Merged

gh-117953: Imply Single-phase Init if the Init Function Fails #118684

merged 1 commit into from
May 7, 2024

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented May 7, 2024 •
edited by bedevere-app bot
Loading

This ensures the kind is always either _Py_ext_module_kind_SINGLEPHASE or _Py_ext_module_kind_MULTIPHASE.

@bedevere-app bedevere-app bot mentioned this pull request May 7, 2024
Open
@ericsnowcurrently ericsnowcurrently merged commit 1a23716 into python:main May 7, 2024
36 checks passed
@ericsnowcurrently ericsnowcurrently deleted the extensions-imply-kind branch May 7, 2024 03:16
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@ericsnowcurrently @SonicField
pythongh-117953: Imply Single-phase Init if the Init Function Fails (p…
69baf02 
…ythongh-118684)

This ensures the kind is always either _Py_ext_module_kind_SINGLEPHASE or _Py_ext_module_kind_MULTIPHASE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericsnowcurrently