Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111201: Allow bracketed paste to work #118700

Merged
merged 6 commits into from
May 7, 2024
Merged

gh-111201: Allow bracketed paste to work #118700

merged 6 commits into from
May 7, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 7, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 7, 2024
Closed
7 tasks
@pablogsal pablogsal force-pushed the enable_bracketed_paste branch from e438388 to 4315668 Compare May 7, 2024 11:52
@pablogsal pablogsal requested review from hauntsaninja and hugovk May 7, 2024 11:55
@pablogsal pablogsal requested a review from ambv May 7, 2024 11:56
lysnikolaou
lysnikolaou reviewed May 7, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitty comments. Feel free to merge.

Lib/_pyrepl/commands.py Outdated Show resolved Hide resolved
Lib/_pyrepl/simple_interact.py Outdated Show resolved Hide resolved
@pablogsal
Copy link
Member Author

CC: @Yhg1s

lysnikolaou
lysnikolaou approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one more nitty comment.

Lib/_pyrepl/unix_console.py Outdated Show resolved Hide resolved
@ambv ambv enabled auto-merge (squash) May 7, 2024 12:26
@ambv ambv merged commit 7d90b8a into python:main May 7, 2024
39 checks passed
@pablogsal pablogsal deleted the enable_bracketed_paste branch May 7, 2024 12:55
@hauntsaninja
Copy link
Contributor

Amazing! I love living in this synthwave future

SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@pablogsal @SonicField
pythongh-111201: Allow bracketed paste to work (pythonGH-118700)
7e72daa
cfbolz added a commit to pypy/pypy that referenced this pull request Jul 29, 2024
@cfbolz
implement bracketed paste in pyrepl
15699e9 
as far as I'm aware this should make gh-2880 go away (not 100% sure,
don't have a mac to test).

backport of parts of python/cpython#118700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@ambv ambv ambv approved these changes

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

@hugovk hugovk Awaiting requested review from hugovk

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @hauntsaninja @ambv @lysnikolaou