Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-118760: Restore the default value of tkinter.wantobjects to 1 #118784

Merged
merged 2 commits into from
May 20, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 8, 2024

@Eclips4 Eclips4 changed the title gh-118760: Restore the default value of tkiter.wantobjects to 1 gh-118760: Restore the default value of tkinter.wantobjects to 1 May 8, 2024
Add support for passing arguments to callbacks registered in the :mod:`tkinter`
module as various Python objects (``int``, ``float``, ``bytes``, ``tuple``),
corresponding to the original Tcl value, not just ``str``, and enable this by default.
To restore the previous behavior set :mod:`!tkinter` module global
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not make sense when the value already is 1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an edited NEWS entry for 3.13.0b1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to 3.13 what's new suggests that the change to wantobjects will be backported also. 'Restoring' 1 to 1 is what I questioned.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an edited NEWS entry for 3.13.0b1. We cannot simply remove it, because it is the part of the history, and 3.13.0b1 was already released with the bug.

But I reworded it, focusing on the possibility to change the behavior and adding that it was changed by default (not for long, for 3.13.0b1 only). So "restoring" here refers to the changed default. How to write this better? Maybe just remove all starting from "To restore"? And add the description of how to enable the experimental feature in the new NEWS entry for 3.13.0b2?

@serhiy-storchaka serhiy-storchaka merged commit e188527 into python:main May 20, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the tkinter-wantobject-1 branch May 20, 2024 19:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
pythonGH-118784)

It was set to 2 in 65f5e58 (pythonGH-98592).
(cherry picked from commit e188527)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

GH-119251 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
serhiy-storchaka added a commit that referenced this pull request May 20, 2024
… 1 (GH-118784) (GH-119251)

It was set to 2 in 65f5e58 (GH-98592).
(cherry picked from commit e188527)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants