Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118849: Fix "code will never be executed" warning in dictobject.c #118850

Merged
merged 2 commits into from
May 9, 2024
Merged

gh-118849: Fix "code will never be executed" warning in dictobject.c #118850

merged 2 commits into from
May 9, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 9, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels May 9, 2024
@sobolevn sobolevn requested a review from colesbury May 9, 2024 15:31
@bedevere-app bedevere-app bot mentioned this pull request May 9, 2024
Closed
colesbury
colesbury reviewed May 9, 2024
View reviewed changes
Objects/dictobject.c Outdated Show resolved Hide resolved
@sobolevn sobolevn merged commit 82abe75 into python:main May 9, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@sobolevn @miss-islington
pythongh-118849: Fix "code will never be executed" warning in `dictob…
9b2ac2e 
…ject.c` (pythonGH-118850)

(cherry picked from commit 82abe75)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

GH-118859 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
@sobolevn
Copy link
Member Author

sobolevn commented May 9, 2024

Thanks for the good catch and for the review! :)

sobolevn added a commit that referenced this pull request May 9, 2024
@miss-islington @sobolevn
[3.13] gh-118849: Fix "code will never be executed" warning in `dicto…
098eec9 
…bject.c` (GH-118850) (#118859)

gh-118849: Fix "code will never be executed" warning in `dictobject.c` (GH-118850)
(cherry picked from commit 82abe75)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@sobolevn @SonicField
pythongh-118849: Fix "code will never be executed" warning in `dictob…
63af4b5 
…ject.c` (python#118850)
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @colesbury