Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename notimplemented_methods into nodefault_methods #118896

Merged
merged 1 commit into from
May 10, 2024
Merged

Rename notimplemented_methods into nodefault_methods #118896

merged 1 commit into from
May 10, 2024

Conversation

sobolevn
Copy link
Member

This naming is probably a left-over from copy-pasting the NotImplemented implementation. It should be fixed.

@sobolevn sobolevn requested a review from JelleZijlstra May 10, 2024 12:24
@sobolevn sobolevn requested a review from markshannon as a code owner May 10, 2024 12:24
JelleZijlstra
JelleZijlstra approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks. Let's backport this in case we need to tweak the implementation of NoDefault more.

@JelleZijlstra JelleZijlstra added the needs backport to 3.13 bugs and security fixes label May 10, 2024
@sobolevn sobolevn enabled auto-merge (squash) May 10, 2024 12:40
@sobolevn sobolevn merged commit 004db21 into python:main May 10, 2024
40 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
@sobolevn @miss-islington
Rename notimplemented_methods into nodefault_methods (pythonGH-11…
96d2fc3 
…8896)

(cherry picked from commit 004db21)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

GH-118898 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 10, 2024
sobolevn added a commit that referenced this pull request May 10, 2024
@miss-islington @sobolevn
[3.13] Rename notimplemented_methods into nodefault_methods (GH-1…
93fce2d 
…18896) (#118898)

Rename `notimplemented_methods` into `nodefault_methods` (GH-118896)
(cherry picked from commit 004db21)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @JelleZijlstra @AlexWaygood