Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118844: Fix --disable-gil & --enable-experimental-jit fails to build #118935

Merged
merged 5 commits into from
May 11, 2024
Merged

gh-118844: Fix --disable-gil & --enable-experimental-jit fails to build #118935

merged 5 commits into from
May 11, 2024

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented May 11, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 11, 2024
Closed
@savannahostrowski
Copy link
Member Author

savannahostrowski commented May 11, 2024 •
edited
Loading

Also, make patchcheck fixed up a couple formatting issues in files? Not sure that the one in the trampoline file is desirable?

brandtbucher
brandtbucher approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pretty cool to see these features being used together.

Python/perf_jit_trampoline.c Outdated Show resolved Hide resolved
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.13 bugs and security fixes labels May 11, 2024
@brandtbucher
Copy link
Member

Can you add a NEWS entry, too?

savannahostrowski and others added 3 commits May 11, 2024 14:20
@savannahostrowski @brandtbucher
Update Misc/NEWS.d/next/Core and Builtins/2024-05-11-21-44-17.gh-issu…
4000624 
…e-118844.q2H_km.rst

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@brandtbucher brandtbucher self-assigned this May 11, 2024
@brandtbucher brandtbucher merged commit 5b941e5 into python:main May 11, 2024
54 checks passed
@miss-islington-app
Copy link

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2024
@savannahostrowski @miss-islington
pythonGH-118844: Fix build failures when combining --disable-gil with…
f3612d8 
… --enable-experimental-jit (pythonGH-118935)

(cherry picked from commit 5b941e5)

Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 11, 2024

GH-118959 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 11, 2024
@stonebig stonebig mentioned this pull request May 12, 2024
Closed
11 tasks
@savannahostrowski savannahostrowski mentioned this pull request May 21, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@savannahostrowski @estyxx
pythonGH-118844: Fix build failures when combining --disable-gil with…
7652b6e 
… --enable-experimental-jit (pythonGH-118935)
@savannahostrowski savannahostrowski deleted the disable-gil-and-jit branch September 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savannahostrowski @brandtbucher