Use literal syntax in origin property #119029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rffontenelle
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
bedevere-app
bot
added
docs
JelleZijlstra
added
needs backport to 3.12
JelleZijlstra
approved these changes
May 14, 2024
hauntsaninja
approved these changes
May 16, 2024
|
Thanks @rffontenelle for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 16, 2024
(cherry picked from commit 66b73e9) Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
|
Sorry, @rffontenelle and @hauntsaninja, I could not cleanly backport this to |
|
GH-119083 is a backport of this pull request to the 3.13 branch. |
hauntsaninja
pushed a commit
that referenced
this pull request
May 16, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this syntax markup, a translator translating library/importlib.metadata.rst could think that "origin" should be translated when the context shows it is a property name for Distribution class.
The context is:
📚 Documentation preview 📚: https://cpython-previews--119029.org.readthedocs.build/