Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-118447: Fix FreeBSD test failures. #119170

Merged
merged 1 commit into from
May 19, 2024

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented May 19, 2024

Follow-up to #118489. Apparently only macOS requires read permission to call readlink() on a symlink.

Apparently only macOS requires read permission to call `readlink()` on a
symlink.
@barneygale barneygale added the needs backport to 3.13 bugs and security fixes label May 19, 2024
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels May 19, 2024
@barneygale barneygale merged commit 4b76671 into python:main May 19, 2024
35 checks passed
@miss-islington-app
Copy link

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2024
Apparently only macOS requires read permission to call `readlink()` on a
symlink.
(cherry picked from commit 4b76671)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 19, 2024

GH-119181 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 19, 2024
barneygale added a commit that referenced this pull request May 19, 2024
GH-118447: Fix FreeBSD test failures. (GH-119170)

Apparently only macOS requires read permission to call `readlink()` on a
symlink.
(cherry picked from commit 4b76671)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Apparently only macOS requires read permission to call `readlink()` on a
symlink.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant