Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119102: Fix REPL for dumb terminal #119332

Merged
merged 2 commits into from
May 21, 2024
Merged

gh-119102: Fix REPL for dumb terminal #119332

merged 2 commits into from
May 21, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 21, 2024 •
edited by bedevere-app bot
Loading

The site module gets the main module to get _pyrepl.main.

@vstinner
pythongh-119102: Fix REPL for dumb terminal
b2549d1 
The site module gets the __main__ module to get _pyrepl.__main__.
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label May 21, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 21, 2024
Closed
@vstinner vstinner mentioned this pull request May 21, 2024
Merged
lysnikolaou
lysnikolaou reviewed May 21, 2024
View reviewed changes
Lib/site.py Outdated Show resolved Hide resolved
@lysnikolaou lysnikolaou added skip news topic-repl Related to the interactive shell labels May 21, 2024
lysnikolaou
lysnikolaou approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eugenetriguba
Copy link
Contributor

eugenetriguba commented May 21, 2024 •
edited
Loading

@vstinner I took a crack at it here when I noticed the first PR that had the mypy fix reverted the bug fix: #119328. Do you have a preference of approach? Happy to close that one out or try to get that test properly working in that PR and just try to get that merged in instead 🙂

danielhollas
danielhollas approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@vstinner vstinner enabled auto-merge (squash) May 21, 2024 18:55
@vstinner
Copy link
Member Author

Thanks for the review and testing!

@vstinner vstinner merged commit de8f530 into python:main May 21, 2024
35 checks passed
@vstinner vstinner deleted the pyrepl_dumb2 branch May 21, 2024 20:33
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@vstinner @miss-islington
pythongh-119102: Fix REPL for dumb terminal (pythonGH-119332)
bb5c037 
The site module gets the __main__ module to get _pyrepl.__main__.
(cherry picked from commit de8f530)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

GH-119359 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 21, 2024
lysnikolaou pushed a commit that referenced this pull request May 22, 2024
@miss-islington @vstinner
[3.13] gh-119102: Fix REPL for dumb terminal (GH-119332) (#119359)
f371565 
The site module gets the __main__ module to get _pyrepl.__main__.
(cherry picked from commit de8f530)

Co-authored-by: Victor Stinner <vstinner@python.org>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119102: Fix REPL for dumb terminal (python#119332)
d25ceee 
The site module gets the __main__ module to get _pyrepl.__main__.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@danielhollas danielhollas danielhollas approved these changes

Assignees
No one assigned
Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @eugenetriguba @danielhollas @lysnikolaou