CI: set correct working directory for Hypothesis cache #119345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
previously approved these changes
May 22, 2024
auto-merge was automatically disabled
May 22, 2024 16:33
Head branch was pushed to by a user without write access
Zac-HD
force-pushed
the
zac/fix-hypothesis-ci-caching
branch
from
791c418 to
219de60
Compare
|
Marking as draft; I'll mark ready-for-review once I see a build which successfully uploaded the cache and artifact. |
|
GitHub might be using the main branch's actions rather than those from this PR. |
Zac-HD
force-pushed
the
zac/fix-hypothesis-ci-caching
branch
from
219de60 to
3a51825
Compare
Zac-HD
force-pushed
the
zac/fix-hypothesis-ci-caching
branch
from
083f0eb to
dbfb2e6
Compare
|
@encukou got it! The problem was that |
|
Thanks! |
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Set cwd for Hypothesis database
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Set cwd for Hypothesis database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when pairing with @encukou that this cache logic never found any files to upload (nor restore).
This isn't a huge problem, but ensuring that we replay any known failing examples on your branch is a nicer developer experience, made possible by persisting the cache between runs.