Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111201: Improve pyrepl auto indentation #119606

Merged
merged 1 commit into from
May 31, 2024
Merged

gh-111201: Improve pyrepl auto indentation #119606

merged 1 commit into from
May 31, 2024

Conversation

wiggin15
Copy link
Contributor

@wiggin15 wiggin15 commented May 27, 2024 •
edited by bedevere-app bot
Loading

  • auto-indent when editing multi-line block
  • ignore comments

@wiggin15
Improve pyrepl auto indentation
596cd0e 
- auto-indent when editing multi-line block
- ignore comments
@bedevere-app bedevere-app bot mentioned this pull request May 27, 2024
Closed
7 tasks
@ambv ambv added topic-repl Related to the interactive shell skip news needs backport to 3.13 bugs and security fixes labels May 31, 2024
@ambv ambv merged commit dae0375 into python:main May 31, 2024
43 checks passed
@miss-islington-app
Copy link

Thanks @wiggin15 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@wiggin15 @miss-islington
pythongh-111201: Improve pyrepl auto indentation (pythonGH-119606)
6f4bf54 
- auto-indent when editing multi-line block
- ignore comments
(cherry picked from commit dae0375)

Co-authored-by: Arnon Yaari <wiggin15@yahoo.com>
@bedevere-app
Copy link

bedevere-app bot commented May 31, 2024

GH-119833 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 31, 2024
@ambv
Copy link
Contributor

ambv commented May 31, 2024

Thanks, Arnon! ✨ 🍰 ✨

ambv pushed a commit that referenced this pull request May 31, 2024
@miss-islington @wiggin15
[3.13] gh-111201: Improve pyrepl auto indentation (GH-119606) (GH-119833
38bf39c 
)

- auto-indent when editing multi-line block
- ignore comments

(cherry picked from commit dae0375)

Co-authored-by: Arnon Yaari <wiggin15@yahoo.com>
@pablogsal
Copy link
Member

Does this close #119356 ?

@lysnikolaou
Copy link
Contributor

It does AFAIU.

@lysnikolaou lysnikolaou mentioned this pull request Jun 4, 2024
Closed
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@wiggin15 @noahbkim
pythongh-111201: Improve pyrepl auto indentation (python#119606)
6389dac 
- auto-indent when editing multi-line block
- ignore comments
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@wiggin15 @estyxx
pythongh-111201: Improve pyrepl auto indentation (python#119606)
46f6acb 
- auto-indent when editing multi-line block
- ignore comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wiggin15 @ambv @pablogsal @lysnikolaou