Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Only install sphinx-autobuild for make htmllive #119607

Merged
merged 2 commits into from
May 27, 2024
Merged

Docs: Only install sphinx-autobuild for make htmllive #119607

merged 2 commits into from
May 27, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented May 27, 2024 •
edited by github-actions bot
Loading

Doctest is failing on the CI because sphinx-autobuild depends on watchfiles, which is Rust and had a new release 2h ago, and fails with a Python 3.14 build:

error: the configured Python interpreter version (3.14) is newer than PyO3's maximum supported version (3.12)
= help: please check if an updated version of PyO3 is available. Current version: 0.21.2
= help: set PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 to suppress this check and build anyway using the stable ABI

https://github.com/python/cpython/actions/runs/9256019877/job/25462093382?pr=119541#step:7:161

we don't need sphinx-autobuild on the CI, let's only install it when doing make htmllive.

📚 Documentation preview 📚: https://cpython-previews--119607.org.readthedocs.build/

This was referenced May 27, 2024
Merged
Merged
vstinner
vstinner approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner mentioned this pull request May 27, 2024
Closed
@hugovk hugovk merged commit 88e3fee into python:main May 27, 2024
27 checks passed
@hugovk hugovk deleted the sphinx-autobuild-only-for-htmllive branch May 27, 2024 17:29
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2024
@hugovk @miss-islington
Docs: Only install sphinx-autobuild for make htmllive (pythonGH-119607
4a2156d 
)

(cherry picked from commit 88e3fee)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 27, 2024

GH-119621 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2024
@hugovk @miss-islington
Docs: Only install sphinx-autobuild for make htmllive (pythonGH-119607
ffdd1b8 
)

(cherry picked from commit 88e3fee)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 27, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 27, 2024

GH-119622 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 27, 2024
hugovk added a commit that referenced this pull request May 27, 2024
@miss-islington @hugovk
[3.12] Docs: Only install sphinx-autobuild for make htmllive (GH-11…
e658d87 
…9607) (#119622)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request May 27, 2024
@miss-islington @hugovk
[3.13] Docs: Only install sphinx-autobuild for make htmllive (GH-11…
ba71835 
…9607) (#119621)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@hugovk @estyxx
Docs: Only install sphinx-autobuild for make htmllive (python#119607)
e662f55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @vstinner