Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] gh-117398: Add multiphase support to _datetime (gh-119373) #119636

Merged
merged 1 commit into from
May 27, 2024
Merged

[3.13] gh-117398: Add multiphase support to _datetime (gh-119373) #119636

merged 1 commit into from
May 27, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 27, 2024 •
edited by bedevere-app bot
Loading

This is minimal support. Subinterpreters are not supported yet. That will be addressed in a later change.

(cherry picked from commit 3e8b609)

Co-authored-by: Erlend E. Aasland erlend@python.org
Co-authored-by: Eric Snow ericsnowcurrently@gmail.com

@erlend-aasland @ericsnowcurrently @miss-islington
pythongh-117398: Add multiphase support to _datetime (pythongh-119373)
ec809db 
This is minimal support.  Subinterpreters are not supported yet.  That will be addressed in a later change.

(cherry picked from commit 3e8b609)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
This was referenced May 27, 2024
Closed
Merged
@ericsnowcurrently ericsnowcurrently merged commit d58ebf0 into python:3.13 May 27, 2024
34 checks passed
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2024
@ericsnowcurrently
Revert "[3.13] pythongh-117398: Add multiphase support to _datetime (p…
e96963a 
…ythongh-119373) (pythongh-119636)"

This reverts commit d58ebf0.
@ericsnowcurrently
Copy link
Member

This broke a bunch of the 3.13 buildbots so I'm reverting it for now.

@ericsnowcurrently
Copy link
Member

For example: https://buildbot.python.org/all/#builders/1508/builds/69

test_utc_alias (test.datetimetester.TestModule_Pure.test_utc_alias) ... ok
test_utc_alias (test.datetimetester.TestModule_Fast.test_utc_alias) ... FAIL
======================================================================
FAIL: test_utc_alias (test.datetimetester.TestModule_Fast.test_utc_alias)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL7-x86_64/build/Lib/test/datetimetester.py", line 98, in test_utc_alias
    self.assertIs(UTC, timezone.utc)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc
----------------------------------------------------------------------
Ran 2 tests in 0.007s
FAILED (failures=1)
test test_datetime failed

@ericsnowcurrently
Copy link
Member

Hmm, looks like I forgot to backport gh-119472.

ericsnowcurrently added a commit that referenced this pull request May 28, 2024
@ericsnowcurrently
[3.13] gh-117398: Revert gh-119636, Add multiphase support to _dateti…
9216a53 
…me (#119639)

Revert "[3.13] gh-117398: Add multiphase support to _datetime (gh-119373) (gh-119636)"

This reverts commit d58ebf0.
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2024
@ericsnowcurrently
Revert "[3.13] pythongh-117398: Revert pythongh-119636, Add multiphas…
c5f7264 
…e support to _datetime (python#119639)"

This reverts commit 9216a53.
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 28, 2024
Merged
ericsnowcurrently added a commit that referenced this pull request May 29, 2024
@ericsnowcurrently
[3.13] gh-117398: Add multiphase support to _datetime (gh-119694)
af57832 
This is an unrevert of d58ebf0 (gh-119636), which was reverted by 9216a53 (gh-119639) due to problems which have been resolved.

This is minimal support for multiphase init. Subinterpreters are not supported yet. That will be addressed in a later change.

(cherry picked from commit 3e8b609)

Co-authored-by: Erlend E. Aasland erlend@python.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miss-islington @ericsnowcurrently @erlend-aasland