Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117398: Convert datetime.IsoCalendarDate To A Heap Type #119637

Merged
merged 3 commits into from
May 28, 2024
Merged

gh-117398: Convert datetime.IsoCalendarDate To A Heap Type #119637

merged 3 commits into from
May 28, 2024

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented May 27, 2024 •
edited by bedevere-app bot
Loading

This is the only static type in the module that we will not keep static.

@bedevere-app bedevere-app bot mentioned this pull request May 27, 2024
Closed
@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review May 27, 2024 22:39
@ericsnowcurrently ericsnowcurrently removed the request for review from abalkin May 27, 2024 22:39
@ericsnowcurrently ericsnowcurrently merged commit 548a11d into python:main May 28, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@ericsnowcurrently ericsnowcurrently deleted the datetime-convert-heap-types branch May 28, 2024 22:42
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2024
@ericsnowcurrently @miss-islington
pythongh-117398: Convert datetime.IsoCalendarDate To A Heap Type (pyt…
b4f7061 
…hongh-119637)

This is the only static type in the module that we will not keep static.
(cherry picked from commit 548a11d)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2024

GH-119695 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 28, 2024
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 29, 2024
Merged
ericsnowcurrently pushed a commit that referenced this pull request May 30, 2024
@miss-islington
[3.13] gh-117398: Convert datetime.IsoCalendarDate To A Heap Type (gh…
5a037b7 
…-119637) (gh-119695)

This is the only static type in the module that we will not keep static.

(cherry picked from commit 548a11d)
(cherry-picked from commit 34f9b3e)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Co-authored by: Kirill Podoprigora <kirill.bast9@mail.ru>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@ericsnowcurrently @noahbkim
pythongh-117398: Convert datetime.IsoCalendarDate To A Heap Type (pyt…
1008aee 
…hongh-119637)

This is the only static type in the module that we will not keep static.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@ericsnowcurrently @estyxx
pythongh-117398: Convert datetime.IsoCalendarDate To A Heap Type (pyt…
4ae6a15 
…hongh-119637)

This is the only static type in the module that we will not keep static.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnowcurrently @erlend-aasland