Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-117398: Statically Allocate the Datetime C-API (GH-119472) #119641

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented May 28, 2024

This is a backport of 3 commits that go together.

(cherry picked from commit a895756)
(cherry picked from commit b30d30c)
(cherry picked from commit a89fc26)

@ericsnowcurrently ericsnowcurrently changed the title gh-117398: Statically Allocate the Datetime C-API (GH-119472) [3.13] gh-117398: Statically Allocate the Datetime C-API (GH-119472) May 28, 2024
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 28, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit b263387 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 28, 2024
@ericsnowcurrently
Copy link
Member Author

FYI, I'm planning on adding the merge commit from gh-119662 here once that PR is merged.

vstinner and others added 3 commits May 28, 2024 13:18
Move types to the datetime_state structure of the _datetime
extension.
…don't free it (pythonGH-119662)

- While datetime uses global state, only initialize it once.
- While `capi` is static, don't free it (thanks @neonene in https://github.com/python/cpython/pull/119641/files#r1616710048)
@ericsnowcurrently ericsnowcurrently force-pushed the datetime-capi-static-objects-3.13 branch from b263387 to 099fd05 Compare May 28, 2024 19:21
@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) May 28, 2024 19:27
@ericsnowcurrently ericsnowcurrently merged commit 12a580b into python:3.13 May 28, 2024
34 of 35 checks passed
@ericsnowcurrently ericsnowcurrently deleted the datetime-capi-static-objects-3.13 branch May 28, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants