gh-119679: Ensures correct import libraries are included in Windows installs #119790
+23
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zooba
commented
May 30, 2024
•
zooba
commented
- Issue: Windows installer missing free-threading library #119679
itamaro
approved these changes
Jun 1, 2024
| @@ -0,0 +1 @@ | |||
| Ensures correct import libraries are included in Windows installs. | |||
There was a problem hiding this comment.
if my understanding is correct, this changes what libraries are included only when opting in to the free-threaded binaries, right?
Suggested change
| Ensures correct import libraries are included in Windows installs. | |
| Ensures correct import libraries are included in Windows installs when installing free-threaded binaries. |
There was a problem hiding this comment.
It also changes the ones included in the Nuget package or anything you might create using the PC/layout script, but it was noticed because of the free threaded package. It's only a fix for a beta, so I'm not too concerned about people noticing and needing to check the release notes.
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2024
…dows install packages (pythonGH-119790) (cherry picked from commit fd01271) Co-authored-by: Steve Dower <steve.dower@python.org>
|
GH-119983 is a backport of this pull request to the 3.13 branch. |
mliezun
pushed a commit
to mliezun/cpython
that referenced
this pull request
Jun 3, 2024
…dows install packages (pythonGH-119790)
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
…dows install packages (pythonGH-119790)
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…dows install packages (pythonGH-119790)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…dows install packages (pythonGH-119790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.