Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111201: Skip pyrepl Windows tests earlier #119848

Merged
merged 1 commit into from
May 31, 2024
Merged

gh-111201: Skip pyrepl Windows tests earlier #119848

merged 1 commit into from
May 31, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 31, 2024 •
edited
Loading

Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing.

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels May 31, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 31, 2024
Closed
7 tasks
@vstinner vstinner changed the title gh-111201: Skip pyperl Windows tests earlier gh-111201: Skip pyrepl Windows tests earlier May 31, 2024
@vstinner
Copy link
Member Author

Example of failiure on FreeBSD where _ctypes extension is missing: https://buildbot.python.org/all/#/builders/1232/builds/2462

0:10:59 load avg: 3.41 [403/478/1] test_pyrepl failed (uncaught exception)
Failed to import test module: test.test_pyrepl.test_windows_console
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/loader.py", line 396, in _find_test_path
    module = self._get_module_from_name(name)
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/loader.py", line 339, in _get_module_from_name
    __import__(name)
    ~~~~~~~~~~^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_pyrepl/test_windows_console.py", line 5, in <module>
    from _pyrepl.windows_console import (
    ...<5 lines>...
    )
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/_pyrepl/windows_console.py", line 30, in <module>
    import ctypes
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/ctypes/__init__.py", line 8, in <module>
    from _ctypes import Union, Structure, Array
ModuleNotFoundError: No module named '_ctypes'

test test_pyrepl crashed -- Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 181, in _runtest_env_changed_exc
    _load_run_test(result, runtests)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 138, in _load_run_test
    regrtest_runner(result, test_func, runtests)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 91, in regrtest_runner
    test_result = test_func()
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 135, in test_func
    return run_unittest(test_mod)
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/libregrtest/single.py", line 35, in run_unittest
    raise Exception("errors while loading tests")
Exception: errors while loading tests

@vstinner
pythongh-111201: Skip pyrepl Windows tests earlier
b3a16bc 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.
@vstinner vstinner enabled auto-merge (squash) May 31, 2024 13:50
@vstinner vstinner merged commit 91601a5 into python:main May 31, 2024
33 checks passed
@vstinner vstinner deleted the pyrepl_testwin branch May 31, 2024 14:06
@AlexWaygood
Copy link
Member

FYI, I think that that buildbot failure was already fixed an hour ago, in #119834

@vstinner vstinner mentioned this pull request May 31, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this pull request Jun 1, 2024
@vstinner
pythongh-111201: Skip pyrepl Windows tests earlier (python#119848)
8806c0c 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.

(cherry picked from commit 91601a5)
@bedevere-app
Copy link

bedevere-app bot commented Jun 1, 2024

GH-119924 is a backport of this pull request to the 3.13 branch.

vstinner added a commit that referenced this pull request Jun 1, 2024
@vstinner
[3.13] gh-111201: Skip pyrepl Windows tests earlier (#119848) (#119924)
ac35d96 
gh-111201: Skip pyrepl Windows tests earlier (#119848)

Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.

(cherry picked from commit 91601a5)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner @noahbkim
pythongh-111201: Skip pyrepl Windows tests earlier (python#119848)
94f63ff 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-111201: Skip pyrepl Windows tests earlier (python#119848)
bb58e4a 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @AlexWaygood @pablogsal