Skip to content

bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as necessary). #12003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 1, 2019
Merged

bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as necessary). #12003

merged 15 commits into from
Mar 1, 2019

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Feb 23, 2019 •
edited by bedevere-bot
Loading

@ericsnowcurrently ericsnowcurrently requested a review from a team as a code owner February 24, 2019 23:58
zooba
zooba reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments as you work.

The title is a little deceptive, right? Most of this change is creating the public C API you need for this :)

@ericsnowcurrently ericsnowcurrently changed the title bpo-36097: Use only public C-API in the_xxsubinterpreters module. bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as necessary). Feb 26, 2019
@ericsnowcurrently
Copy link
Member Author

@zooba, yeah, that title was unclear. :) That's what happens when I get neck-deep in a space and why reviews are so important. :)

@ericsnowcurrently ericsnowcurrently merged commit bcfa450 into python:master Mar 1, 2019
@bedevere-bot
Copy link

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!

@ericsnowcurrently ericsnowcurrently deleted the module-uses-public-api branch March 1, 2019 23:50
vstinner added a commit that referenced this pull request Mar 4, 2019
@vstinner
Revert: bpo-33608: Factor out a private, per-interpreter _Py_AddPendi…
4d61e6e 
…ngCall(). (GH-11617) (GH-12159)

* Revert "bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as necessary). (#12003)"

This reverts commit bcfa450.

* Revert "bpo-33608: Simplify ceval's DISPATCH by hoisting eval_breaker ahead of time. (gh-12062)"

This reverts commit bda918b.

* Revert "bpo-33608: Use _Py_AddPendingCall() in _PyCrossInterpreterData_Release(). (gh-12024)"

This reverts commit b05b711.

* Revert "bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (GH-11617)"

This reverts commit ef4ac96.
@ericsnowcurrently ericsnowcurrently restored the module-uses-public-api branch March 8, 2019 16:31
@ericsnowcurrently ericsnowcurrently mentioned this pull request Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericsnowcurrently @bedevere-bot @zooba @the-knights-who-say-ni