gh-119698: fix `symtable.Class.get_methods` and document its behaviour correctly #120151

picnixz · 2024-06-06T10:09:19Z

This is an alternative to #120148.

Issue: symtable.Class.get_methods() returns non-methods #119698

📚 Documentation preview 📚: https://cpython-previews--120151.org.readthedocs.build/

carljm

I think we should also test here that we do identify a PEP 695 generic method (e.g. def f[T](self): ...) as a method.

(I don't have strong opinions about whether we fix or document get_methods, but seems like we may as well fix if this much of the work is already done to fix.)

bedevere-app · 2024-06-06T15:59:31Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

picnixz · 2024-06-07T08:12:34Z

Thank you Carl, I have made the requested changes; please review again. The irony is that I worked on those blocks and I forgot about them in this PR...

bedevere-app · 2024-06-07T08:12:39Z

Thanks for making the requested changes!

@carljm: please review the changes made to this pull request.

Lib/test/test_symtable.py

Lib/symtable.py

bedevere-bot · 2024-06-20T04:52:44Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel ASAN NoGIL 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1366/builds/1481) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1366/builds/1481

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:00:25Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/529/builds/6803) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/529/builds/6803

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:01:58Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/15/builds/8000) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/15/builds/8000

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:02:22Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel NoGIL 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1258/builds/2183) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1258/builds/2183

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.nogil/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.nogil/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:02:46Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/509/builds/6802) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/509/builds/6802

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:02:54Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/179/builds/7619) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/179/builds/7619

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:05:04Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/8902) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/8902

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:05:45Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/185/builds/7094) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/185/builds/7094

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

…ehaviour correctly (#120151) (#120776) (cherry picked from commit b8a8e04) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-bot · 2024-06-20T05:14:26Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/125/builds/6134) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/125/builds/6134

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:15:57Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO + PGO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/244/builds/7561) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/244/builds/7561

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto-pgo/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:17:14Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/442/builds/6871) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/442/builds/6871

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:17:42Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 LTO + PGO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/96/builds/7767) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/96/builds/7767

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:17:46Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/78/builds/7355) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/78/builds/7355

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:23:24Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 LTO + PGO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/568/builds/6805) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/568/builds/6805

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64.lto-pgo/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64.lto-pgo/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:23:35Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang Installed 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/14/builds/6285) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/14/builds/6285

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.14/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.14/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:26:02Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/402/builds/7456) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/402/builds/7456

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:26:42Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/338/builds/7013) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/338/builds/7013

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

…ehaviour correctly (GH-120151) (#120777) (cherry picked from commit b8a8e04) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-bot · 2024-06-20T05:30:43Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/469/builds/8396) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/469/builds/8396

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:31:21Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/567/builds/6797) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/567/builds/6797

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:33:07Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 LTO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/64/builds/7101) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/64/builds/7101

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64.lto/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64.lto/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:45:58Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO + PGO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/524/builds/6137) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/524/builds/6137

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T05:57:35Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/336/builds/5447) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/336/builds/5447

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

bedevere-bot · 2024-06-20T06:14:34Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit b8a8e04.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/506/builds/8182) and take a look at the build logs.
Check if the failure is related to this commit (b8a8e04) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/506/builds/8182

Failed tests:

test_symtable

Failed subtests:

test_class_info - test.test_symtable.SymtableTest.test_class_info

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_symtable.py", line 365, in test_class_info
    self.assertEqual(this.get_methods(), (
                     ~~~~~~~~~~~~~~~~^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/symtable.py", line 253, in get_methods
    case _symtable.TYPE_TYPE_PARAM:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_symtable' has no attribute 'TYPE_TYPE_PARAM'. Did you mean: 'DEF_TYPE_PARAM'?

…haviour correctly (python#120151) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

picnixz added 4 commits June 6, 2024 12:01

fix symtable.Class.get_methods

5b23892

add test

93ea543

add doc

44f50e2

blurb

f8b95d3

bedevere-app bot added the awaiting review label Jun 6, 2024

bedevere-app bot mentioned this pull request Jun 6, 2024

symtable.Class.get_methods() returns non-methods #119698

Closed

picnixz added 4 commits June 6, 2024 12:10

fixup

582906b

fixup whitespaces

f64e302

fixup

6078d24

fixup

f795499

carljm requested changes Jun 6, 2024

View reviewed changes

bedevere-app bot removed the awaiting review label Jun 6, 2024

bedevere-app bot added the awaiting changes label Jun 6, 2024

improve test coverage

8d1f661

picnixz requested a review from carljm June 7, 2024 08:07

bedevere-app bot added awaiting change review and removed awaiting changes labels Jun 7, 2024

Merge branch 'main' into fix-symtable-get-methods

3cbde0d

picnixz mentioned this pull request Jun 8, 2024

gh-119180: PEP 649 compiler changes #119361

Merged

JelleZijlstra reviewed Jun 8, 2024

View reviewed changes

Lib/test/test_symtable.py Show resolved Hide resolved

picnixz added 2 commits June 8, 2024 14:33

add async def cases

fc7f5bb

update comments

1352d08

JelleZijlstra reviewed Jun 8, 2024

View reviewed changes

Lib/symtable.py Outdated Show resolved Hide resolved

picnixz mentioned this pull request Jun 8, 2024

gh-119698: deprecate symtable.Class.get_methods #120148

Closed

prepare for handling PEP 649

62d2d6d

picnixz force-pushed the fix-symtable-get-methods branch from 7197e17 to 62d2d6d Compare June 9, 2024 10:36

unapply restyle

bd05537

picnixz mentioned this pull request Jun 22, 2024

Update symtable stubs for 3.13 and 3.14 python/typeshed#12183

Merged

picnixz deleted the fix-symtable-get-methods branch June 22, 2024 13:01

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024

pythongh-119698: fix symtable.Class.get_methods and document its be…

92a0edf

…haviour correctly (python#120151) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024

pythongh-119698: fix symtable.Class.get_methods and document its be…

9b8c175

…haviour correctly (python#120151) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024

pythongh-119698: fix symtable.Class.get_methods and document its be…

acb9dbf

…haviour correctly (python#120151) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-119698: fix `symtable.Class.get_methods` and document its behaviour correctly #120151

gh-119698: fix `symtable.Class.get_methods` and document its behaviour correctly #120151

picnixz commented Jun 6, 2024 •

edited by github-actions bot

Loading

carljm left a comment

bedevere-app bot commented Jun 6, 2024

picnixz commented Jun 7, 2024

bedevere-app bot commented Jun 7, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

bedevere-bot commented Jun 20, 2024

gh-119698: fix symtable.Class.get_methods and document its behaviour correctly #120151

gh-119698: fix symtable.Class.get_methods and document its behaviour correctly #120151

Conversation

picnixz commented Jun 6, 2024 • edited by github-actions bot Loading

carljm left a comment

Choose a reason for hiding this comment

bedevere-app bot commented Jun 6, 2024

picnixz commented Jun 7, 2024

bedevere-app bot commented Jun 7, 2024

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jun 20, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

gh-119698: fix `symtable.Class.get_methods` and document its behaviour correctly #120151

gh-119698: fix `symtable.Class.get_methods` and document its behaviour correctly #120151

picnixz commented Jun 6, 2024 •

edited by github-actions bot

Loading