Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-120164: Fix test_os.test_win32_mkdir_700 #120177

Merged
merged 3 commits into from
Jun 7, 2024
Merged

gh-120164: Fix test_os.test_win32_mkdir_700 #120177

merged 3 commits into from
Jun 7, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jun 6, 2024 •
edited by bedevere-app bot
Loading

@Eclips4 Eclips4 requested review from eryksun and zooba June 6, 2024 20:19
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Jun 6, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 6, 2024
Closed
@Eclips4 Eclips4 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jun 6, 2024
@zooba
Copy link
Member

zooba commented Jun 6, 2024

LGTM. I assume it works on your machine?

@Eclips4
Copy link
Member Author

Eclips4 commented Jun 7, 2024

LGTM. I assume it works on your machine?

Yes, it is.

eryksun
eryksun approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@eryksun eryksun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

vstinner
vstinner reviewed Jun 7, 2024
View reviewed changes
Lib/test/test_os.py Outdated Show resolved Hide resolved
@Eclips4 @eryksun
Update Lib/test/test_os.py
bc121a4 
Co-authored-by: Eryk Sun <eryksun@gmail.com>
vstinner
vstinner approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit d5ba4fc into python:main Jun 7, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2024
@Eclips4 @eryksun @miss-islington
pythongh-120164: Fix test_os.test_win32_mkdir_700() (pythonGH-120177)
b7d395f 
Don't compare the path to avoid encoding issues.

(cherry picked from commit d5ba4fc)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 7, 2024

GH-120202 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 7, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2024
@Eclips4 @eryksun @miss-islington
pythongh-120164: Fix test_os.test_win32_mkdir_700() (pythonGH-120177)
4479bcd 
Don't compare the path to avoid encoding issues.

(cherry picked from commit d5ba4fc)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 7, 2024

GH-120203 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 7, 2024
@vstinner
Copy link
Member

vstinner commented Jun 7, 2024

Merged, thanks for the fix @Eclips4.

vstinner pushed a commit that referenced this pull request Jun 7, 2024
@miss-islington @Eclips4 @eryksun
[3.12] gh-120164: Fix test_os.test_win32_mkdir_700() (GH-120177) (#12…
3730f60 
…0203)

gh-120164: Fix test_os.test_win32_mkdir_700() (GH-120177)

Don't compare the path to avoid encoding issues.

(cherry picked from commit d5ba4fc)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
vstinner pushed a commit that referenced this pull request Jun 7, 2024
@miss-islington @Eclips4 @eryksun
[3.13] gh-120164: Fix test_os.test_win32_mkdir_700() (GH-120177) (#12…
1e43f76 
…0202)

gh-120164: Fix test_os.test_win32_mkdir_700() (GH-120177)

Don't compare the path to avoid encoding issues.

(cherry picked from commit d5ba4fc)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@Eclips4 Eclips4 deleted the issue-120164 branch June 7, 2024 09:45
@Eclips4
Copy link
Member Author

Eclips4 commented Jun 7, 2024

Thanks for the reviews!

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Eclips4 @eryksun @noahbkim
pythongh-120164: Fix test_os.test_win32_mkdir_700() (python#120177)
4f1b7ba 
Don't compare the path to avoid encoding issues.

Co-authored-by: Eryk Sun <eryksun@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Eclips4 @eryksun @estyxx
pythongh-120164: Fix test_os.test_win32_mkdir_700() (python#120177)
9391004 
Don't compare the path to avoid encoding issues.

Co-authored-by: Eryk Sun <eryksun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eryksun eryksun eryksun approved these changes

@vstinner vstinner vstinner approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eclips4 @zooba @vstinner @eryksun