Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-120560: Mark zip64 tests in test_zipimport as cpu-heavy #120564

Merged
merged 1 commit into from
Jun 17, 2024
Merged

gh-120560: Mark zip64 tests in test_zipimport as cpu-heavy #120564

merged 1 commit into from
Jun 17, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Jun 15, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 15, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jun 15, 2024
@nineteendo nineteendo marked this pull request as ready for review June 15, 2024 18:50
@ncoghlan
Copy link
Contributor

I think bedevere is right on this one: there should be a NEWS entry in the test section noting that running these tests now requires the cpu resource.

The change itself looks fine, though.

@nineteendo
Copy link
Contributor Author

From the devguide:

Most changes made to the codebase deserve an entry in Misc/NEWS.d, except for the following:

  • test changes

@Eclips4
Copy link
Member

Eclips4 commented Jun 16, 2024 •
edited
Loading

I think bedevere is right on this one: there should be a NEWS entry in the test section noting that running these tests now requires the cpu resource.

The change itself looks fine, though.

Previously when we were doing the same thing, we didn't write a NEWS entry, for example: #118801.
But if you want a NEWS entry, I wouldn't argue 🙂. We could write something like Due to high CPU utilization, zip64 tests in test_zipimport were marked as a cpu-heavy tests.

@brettcannon brettcannon merged commit ac37a80 into python:main Jun 17, 2024
40 checks passed
@brettcannon
Copy link
Member

Thanks!

@nineteendo nineteendo deleted the testZip64-require-cpu branch June 18, 2024 04:58
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@nineteendo @mrahtz
pythongh-120560: Mark zip64 tests in test_zipimport as CPU-heavy (p…
9267431 
…ythonGH-120564)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@nineteendo @noahbkim
pythongh-120560: Mark zip64 tests in test_zipimport as CPU-heavy (p…
e67e31c 
…ythonGH-120564)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nineteendo @estyxx
pythongh-120560: Mark zip64 tests in test_zipimport as CPU-heavy (p…
9674a53 
…ythonGH-120564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nineteendo @ncoghlan @Eclips4 @brettcannon