Skip to content

[3.12] gh-120384: Fix array-out-of-bounds crash in list_ass_subscript (GH-120442) #120825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 21, 2024

(cherry picked from commit 8334a1b)

Co-authored-by: Nikita Sobolev mail@sobolevn.me

pythonGH-120442)

(cherry picked from commit 8334a1b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn sobolevn enabled auto-merge (squash) June 21, 2024 10:51
@sobolevn sobolevn merged commit d75eddc into python:3.12 Jun 21, 2024
30 checks passed
@miss-islington-app
Copy link

Thanks @miss-islington for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @miss-islington for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @miss-islington for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @miss-islington for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @miss-islington and @sobolevn, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d75eddcf36986ae971f42fd516f737169081e182 3.9

@miss-islington-app
Copy link

Sorry, @miss-islington and @sobolevn, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d75eddcf36986ae971f42fd516f737169081e182 3.8

@miss-islington-app
Copy link

Sorry, @miss-islington and @sobolevn, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d75eddcf36986ae971f42fd516f737169081e182 3.10

@miss-islington-app
Copy link

Sorry, @miss-islington and @sobolevn, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d75eddcf36986ae971f42fd516f737169081e182 3.11

@gpshead
Copy link
Member

gpshead commented Jul 3, 2024

I'm exploring the feasibility of backports as, while we don't as a project consider the ability to execute arbitrary code when executing Python bytecode a security problem - because arbitrary code is just that. There are projects that'd benefit from this bugfix being in place from a security standpoint. It looks like it'll require some hand-holding to backport.

gpshead pushed a commit to gpshead/cpython that referenced this pull request Jul 3, 2024
pythonGH-120442) (python#120825)

pythongh-120384: Fix array-out-of-bounds crash in `list_ass_subscript` (pythonGH-120442)
(cherry picked from commit 8334a1b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn
Copy link
Member

sobolevn commented Jul 3, 2024

@gpshead do you want me to do that? :)
I can, but a bit later. I am on vacation for several days.

@gpshead
Copy link
Member

gpshead commented Jul 3, 2024

No need, I've already created #121345 for that. I'll let the 3.11 and earlier release managers decide if they want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants