gh-119786: move frames documentation to InternalDocs and add details #121009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Jun 25, 2024
•
iritkatriel
commented
- Issue: create an internals documentation folder in the cpython repo #119786
iritkatriel
added
docs
markshannon
reviewed
Jun 26, 2024
There was a problem hiding this comment.
I've a few suggestions.
Also, FYI:
f_globalsandf_builtinsare likely to be removed soon Speeding up Python-to-Python calls. faster-cpython/ideas#661- We may even move to a two-stack approach Use two call stacks instead of one. faster-cpython/ideas#675
InternalDocs/frames.md
Outdated
|
|
||
| * Local variables (including arguments, cells and free variables) | ||
| * Evaluation stack | ||
| * Evaluation stack and instruction pointer |
There was a problem hiding this comment.
I don't think the instruction pointer belongs here (at least not conceptually).
I would add it to specials/linkage
There was a problem hiding this comment.
How about I change this line to
Execution state: evaluation stack, instruction pointer ?
It feels like instruction pointer is internal to the frame's working, rather than linking to external frames or objects.
|
I think it would make sense to merge the "specials" and "linkage" sections. The only real "linkage" is the So, maybe replace "specials and linkage" with "specials", and when specifically referring to "linkage", say |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.