Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable #121017

Merged
merged 3 commits into from
Jun 26, 2024
Merged

gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable #121017

merged 3 commits into from
Jun 26, 2024

Conversation

devdanzin
Copy link
Contributor

@devdanzin devdanzin commented Jun 26, 2024 •
edited by bedevere-app bot
Loading

This PR adds a test for PYTHON_BASIC_REPL setting the interpreter to use the basic REPL, using a technique suggested by @AlexWaygood on Discord.

@bedevere-app bedevere-app bot mentioned this pull request Jun 26, 2024
Closed
lysnikolaou
lysnikolaou approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @devdanzin!

@lysnikolaou lysnikolaou added needs backport to 3.13 bugs and security fixes topic-repl Related to the interactive shell labels Jun 26, 2024
AlexWaygood
AlexWaygood reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two tiny nits:

Lib/test/test_pyrepl/test_pyrepl.py Show resolved Hide resolved
Lib/test/test_pyrepl/test_pyrepl.py Show resolved Hide resolved
@devdanzin @AlexWaygood
Apply suggestions from code review to double-check that the tests are…
0f0ee39 
… working as expected.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@devdanzin
Copy link
Contributor Author

Thank you Lysandros and Alex!

@AlexWaygood AlexWaygood changed the title gh-121016: Test PYTHON_BASIC_REPL gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable Jun 26, 2024
@AlexWaygood AlexWaygood enabled auto-merge (squash) June 26, 2024 09:59
@AlexWaygood AlexWaygood merged commit 9e45fd9 into python:main Jun 26, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @devdanzin for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @devdanzin and @AlexWaygood, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9e45fd9858a059950f7387b4fda2b00df0e8e537 3.13

@AlexWaygood
Copy link
Member

@devdanzin, would you possibly be able to take care of the backport PR? If you're not familiar with the process, I can do it later

@devdanzin
Copy link
Contributor Author

Thanks for merging!

@devdanzin, would you possibly be able to take care of the backport PR?

I'm not sure I can, I get "Permission denied" at the end of the process:

🐍 🍒 ⛏
Failed to push to origin ☹
branch backport-9e45fd9-3.13 has been deleted.

Backport PR:

[3.13] gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (GH-121017)
(cherry picked from commit 9e45fd9858a059950f7387b4fda2b00df0e8e537)

Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
remote: Permission to python/cpython.git denied to devdanzin.
fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 403

If the right way to do it is to push to my fork first, I can try it tonight. Otherwise, feel free to handle it.

@lysnikolaou
Copy link
Member

If the right way to do it is to push to my fork first, I can try it tonight. Otherwise, feel free to handle it.

That's the right way, yes. You can try it tonight, sure.

devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
547f13d 
…le (python#121017)

(cherry picked from commit 9e45fd9)
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
[3.13] pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment…
1ac30d5 
… variable (pythonGH-121017)

(cherry picked from commit 9e45fd9)

Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
4ecdb52 
…le (python#121017)

(cherry picked from commit 9e45fd9)
devdanzin added a commit to devdanzin/cpython that referenced this pull request Jun 26, 2024
@devdanzin
[3.13] pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment…
65f456b 
… variable (pythonGH-121017)

(cherry picked from commit 9e45fd9)

Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2024

GH-121064 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 26, 2024
AlexWaygood pushed a commit that referenced this pull request Jun 26, 2024
@devdanzin
[3.13] gh-121016: Add test for PYTHON_BASIC_REPL envioronment variable (
bc515b3 
GH-121017) (#121064)

* gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (#121017)

(cherry picked from commit 9e45fd9)

* [3.13] gh-121016: Add test for `PYTHON_BASIC_REPL` envioronment variable (GH-121017)
(cherry picked from commit 9e45fd9)

Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@devdanzin @mrahtz
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
bcd4204 
…le (python#121017)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@devdanzin @noahbkim
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
0bbf153 
…le (python#121017)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@devdanzin @estyxx
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
73474bb 
…le (python#121017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

@AlexWaygood AlexWaygood

Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devdanzin @AlexWaygood @lysnikolaou @sobolevn