Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121196: Document dict.fromkeys params as pos-only #121197

Merged
merged 1 commit into from
Jul 1, 2024
Merged

gh-121196: Document dict.fromkeys params as pos-only #121197

merged 1 commit into from
Jul 1, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 1, 2024 •
edited by github-actions bot
Loading

Please, consider that some subtypes of dict change the signature back to pos-or-keyword args.
But, since this is only about dict, I guess we can be very specific about it.

Do we backport this change?

📚 Documentation preview 📚: https://cpython-previews--121197.org.readthedocs.build/

@sobolevn sobolevn requested a review from hugovk July 1, 2024 07:16
@bedevere-app bedevere-app bot mentioned this pull request Jul 1, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting core review labels Jul 1, 2024
@terryjreedy terryjreedy added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 1, 2024
@terryjreedy
Copy link
Member

Doc patches usually get backported when applicable, especially if they automerge.

@erlend-aasland
Copy link
Contributor

I would prefer to update the whole dict docs page, not only one method.

@sobolevn
Copy link
Member Author

sobolevn commented Jul 1, 2024

@erlend-aasland I think that it is complicated. .get is the most complex one. Since Mapping and dict are not the same here.

So, I would prefer to have a smaller scope for this change.

@sobolevn sobolevn merged commit 1dc9a4f into python:main Jul 1, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@sobolevn @miss-islington
pythongh-121196: Document dict.fromkeys params as pos-only (pythonG…
bda3d4c 
…H-121197)

(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@sobolevn @miss-islington
pythongh-121196: Document dict.fromkeys params as pos-only (pythonG…
7557dc1 
…H-121197)

(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Jul 1, 2024

GH-121242 is a backport of this pull request to the 3.13 branch.

@sobolevn
Copy link
Member Author

sobolevn commented Jul 1, 2024

Thanks everyone!

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 1, 2024
@sobolevn sobolevn added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jul 1, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2024
@sobolevn @miss-islington
pythongh-121196: Document dict.fromkeys params as pos-only (pythonG…
c1050de 
…H-121197)

(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jul 1, 2024
@miss-islington @sobolevn
[3.12] gh-121196: Document dict.fromkeys params as pos-only (GH-121197
e5a19b9 
) (#121243)

gh-121196: Document `dict.fromkeys` params as pos-only (GH-121197)
(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jul 1, 2024
@miss-islington @sobolevn
[3.13] gh-121196: Document dict.fromkeys params as pos-only (GH-121197
78c7732 
) (#121242)

gh-121196: Document `dict.fromkeys` params as pos-only (GH-121197)
(cherry picked from commit 1dc9a4f)

Co-authored-by: sobolevn <mail@sobolevn.me>
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@sobolevn @Akasurde
pythongh-121196: Document dict.fromkeys params as pos-only (python#…
ab15da2 
…121197)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@sobolevn @noahbkim
pythongh-121196: Document dict.fromkeys params as pos-only (python#…
3b74591 
…121197)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-121196: Document dict.fromkeys params as pos-only (python#…
e7b5a6d 
…121197)
@ezio-melotti ezio-melotti mentioned this pull request Jul 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @terryjreedy @erlend-aasland @hugovk