gh-117139: Add _PyTuple_FromStackRefSteal and use it #121244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the extra conversion from stack refs to PyObjects.
|
!buildbot nogil refleak |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 93feb92 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
This fixes the refleak on my branch as well right? I assume so since we no longer hide conversions, and it looks right here. |
Fidget-Spinner
approved these changes
Jul 2, 2024
|
Yes, it should fix the leak as well. |
Akasurde
pushed a commit
to Akasurde/cpython
that referenced
this pull request
Jul 3, 2024
…1244) Avoids the extra conversion from stack refs to PyObjects.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…1244) Avoids the extra conversion from stack refs to PyObjects.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…1244) Avoids the extra conversion from stack refs to PyObjects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the extra conversion from stack refs to PyObjects.