Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-117398: Use the correct module loader for iOS in datetime CAPI test (GH-120477) #121561

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Jul 10, 2024

#119604 added a CAPI test for subinterpreters in the datetime tests; however, the test uses the ExtensionFileLoader to load _testcapi. iOS requires the use of the AppleFrameworkLoader.

(backported from commit 5c58e72, AKA gh-120477)

@neonene

This comment was marked as off-topic.

@bedevere-bot
Copy link

You don't have write permissions to trigger a build

@neonene
Copy link
Contributor Author

neonene commented Jul 10, 2024

@freakboy3742 Could you review the backport? I failed to trigger the iOS build bot.

@freakboy3742
Copy link
Contributor

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 987dd52 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742 freakboy3742 merged commit c08a302 into python:3.13 Jul 10, 2024
37 checks passed
@freakboy3742
Copy link
Contributor

@neonene Thanks for the backport (and nice work hunting down the fix without access to the buildbot!)

@neonene neonene deleted the datetime-capitest branch July 10, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants