Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move misplaced blurb entries #121918

Closed
wants to merge 1 commit into from
Closed

Conversation

Yhg1s
Copy link
Member

@Yhg1s Yhg1s commented Jul 17, 2024

Move misplaced blurb entries from "C_API" to "C API", and from "Core_and_Builtins" to "Core and Builtins".

"Core_and_Builtins" to "Core and Builtins".
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting core review labels Jul 17, 2024
@Yhg1s Yhg1s requested a review from hugovk July 17, 2024 15:12
@ambv
Copy link
Contributor

ambv commented Jul 17, 2024

Shouldn't this rename go the other way?

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blurb <= 1.1.0 wants the old names with spaces.

Blurb >= 1.2.0 can read directories both with spaces and with underscores.

If we merge that PR, we can close (or merge!) this PR.

If @Yhg1s wants to do it the old way for this release, let's merge this one.

@ambv
Copy link
Contributor

ambv commented Jul 17, 2024

I merged the release-tools PR.

@Yhg1s
Copy link
Member Author

Yhg1s commented Jul 17, 2024

I already fixed this for 3.13.0b4 in a separate PR. I sent this PR to Hugo because this is his bailiwick now :)

@hugovk
Copy link
Member

hugovk commented Jul 18, 2024

Thanks! Let's leave it as is, new blurb can read from both.

After today's release is out, we can also merge python/blurb_it#332 and I'll post on Discuss to encourage people to upgrade their blurb CLI. Further down the line, we can add a pre-commit check to prevent creation of dirs with spaces.

@hugovk hugovk closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants