Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122544: Change OS image in GitHub Actions to ubuntu-24.04 #122566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Damien-Chen
Copy link
Contributor

@Damien-Chen Damien-Chen commented Aug 1, 2024

Change base OS image in Github Actions from ubuntu-22.04 to ubuntu-24.04

@bedevere-app
Copy link

bedevere-app bot commented Aug 1, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@hugovk hugovk changed the title gh-122544: Change OS image in github workflow to ubuntu-24.04 gh-122544: Change OS image in GitHub Actions to ubuntu-24.04 Aug 2, 2024
@AA-Turner
Copy link
Member

Failing due to Unable to locate package libmpdec-dev, as the libmpdec-dev package does not appear in Ubuntu 24.04 LTS. According to this comment, the removal is intentional as it is no longer needed, see the debian mailing list post.

@Damien-Chen are you able to test this please?

A

@Damien-Chen
Copy link
Contributor Author

Failing due to Unable to locate package libmpdec-dev, as the libmpdec-dev package does not appear in Ubuntu 24.04 LTS. According to this comment, the removal is intentional as it is no longer needed, see the debian mailing list post.

@Damien-Chen are you able to test this please?

A

Sure!. No problem!

@AA-Turner
Copy link
Member

The regen-all check is failing, I assume something changed between LTS versions -- can you run make regen-all on 24.04 and push that?

A

@Damien-Chen
Copy link
Contributor Author

The regen-all check is failing, I assume something changed between LTS versions -- can you run make regen-all on 24.04 and push that?

A

Let me check if I can test it locally on my WSL2 ubuntu-24.04 or use another local machine to install ubuntu-24.04. Or if I can trigger all pipline on my fork repo so that I I don’t have to confirm the result every time I commit to this PR.

@Damien-Chen
Copy link
Contributor Author

Damien-Chen commented Aug 3, 2024

The regen-all check is failing, I assume something changed between LTS versions -- can you run make regen-all on 24.04 and push that?

A

It means that adding make regen-all before git add -u like the below image show?

  - name: Check for changes
    run: |
      make regen-all
      git add -u
      changes=$(git status --porcelain)

@Damien-Chen
Copy link
Contributor Author

It seems same error, I run on my forked repo in this

@AA-Turner
Copy link
Member

Sorry, I meant you need to run make regen-all locally and commit the output of that to your branch.

@Damien-Chen
Copy link
Contributor Author

Sorry, I meant you need to run make regen-all locally and commit the output of that to your branch.

It seems that the below three file cause error in ubuntu-24.04
aclocal.m4, config.guess, configure.

I test it in several method. First is run make regen-all on my local ubuntun-24.04 machine, and convert the whole output into a script, and then execute it before running Check for changes test but it fails.
Then I copy the above three mention file generated in ubuntu-24.04, and overwrite the original three file that in ubuntu-22.04 and it seems pass the check.

Maybe there are some modification between ubuntu-22.04 and ubuntu-24.04 cause the above mentioned three file different ?

The whole process and result were conduct in my fork repo here

ubuntu-24.04output.txt

And the attached file is the output of running make regen-all in ubuntu-24.04.

@Damien-Chen
Copy link
Contributor Author

For ubuntu-24.04, these three file aclocal.m4, config.guess, configure are different than ubuntu-22.04. Maybe we should update these file together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants