Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON #122764

Merged
merged 1 commit into from
Aug 8, 2024
Merged

gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON #122764

merged 1 commit into from
Aug 8, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Aug 6, 2024 •
edited by bedevere-app bot
Loading

This variable was renamed to MODULE_LDFLAGS in #115780, but as discussed at #115780 (comment), Meson depends on the old name LIBPYTHON. Some other package build scripts probably have the same issue.

@mhsmith mhsmith added the needs backport to 3.13 bugs and security fixes label Aug 6, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 6, 2024
Closed
This was referenced Aug 6, 2024
Closed
Merged
rgommers
rgommers approved these changes Aug 7, 2024
View reviewed changes
Copy link

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix @mhsmith, much appreciated.

I did do a quick check - this rename is complete, no `MODULE_LDFLAGS left except for the news snippet added here.

erlend-aasland
erlend-aasland approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mhsmith
Copy link
Member Author

mhsmith commented Aug 8, 2024

@erlend-aasland: Thanks; are you able to merge this? There will also be a 3.13 backport.

@erlend-aasland erlend-aasland merged commit 2f5c3b0 into python:main Aug 8, 2024
43 checks passed
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
@mhsmith @miss-islington
pythongh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTH…
63b0faf 
…ON (pythonGH-122764)

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
(cherry picked from commit 2f5c3b0)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 8, 2024

GH-122842 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 8, 2024
gpshead pushed a commit that referenced this pull request Aug 9, 2024
@miss-islington @mhsmith
[3.13] gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYT…
42005c7 
…HON (GH-122764) (GH-122842)

gh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTHON (GH-122764)

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
(cherry picked from commit 2f5c3b0)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@mhsmith @blhsing
pythongh-116622: Rename build variable MODULE_LDFLAGS back to LIBPYTH…
479e4bd 
…ON (python#122764)

(LIBPYTHON was renamed MODULE_LDFLAGS in commit 7f5e3f0.)
@mhsmith mhsmith mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@rgommers rgommers rgommers approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsmith @rgommers @erlend-aasland