Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-122247: Move instruction instrumentation sanity check after tracing check (GH-122251) #122812

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 8, 2024

…tracing check (pythonGH-122251)

(cherry picked from commit 57d7c3e)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@gaogaotiantian
Copy link
Member

@markshannon I think because 3.13 is in rc now I should ask for approval even for backport PR

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward backport of an approved PR. The added test fails now and the PR fixes it. It only touches assert and so it should have no effect on production code.

IMO, it should go in 3.13rc2.

@encukou encukou merged commit 1f70715 into python:3.13 Aug 16, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants