[3.11] gh-122905: Sanitize names in zipfile.Path. (GH-122906) #122925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jaraco
commented
Aug 12, 2024
•
jaraco
commented
- Issue: Malformed payload can lead to infinite loops in zipfile.Path #122905
Ported from zipp 3.19.1; ref jaraco/zipp#119. (cherry picked from commit 9cd0326)
) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
This was referenced Aug 12, 2024
|
@pablogsal I'm interested in your review to confirm that you agree this change addresses a security issue per the release policy. |
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Aug 19, 2024
…nGH-122906) (pythonGH-122925) * pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) * [3.11] pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) (cherry picked from commit 795f259) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
|
GH-123160 is a backport of this pull request to the 3.10 branch. |
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Aug 19, 2024
…GH-122906) (pythonGH-122925) * pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) * [3.11] pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) (cherry picked from commit 795f259) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
pablogsal
pushed a commit
that referenced
this pull request
Aug 22, 2024
[3.10] [3.11] gh-122905: Sanitize names in zipfile.Path. (GH-122906) (GH-122925) * gh-122905: Sanitize names in zipfile.Path. (GH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) * [3.11] gh-122905: Sanitize names in zipfile.Path. (GH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) (cherry picked from commit 795f259)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.