gh-122965: Fix reusable-change-detection.yml on workflow_dispatch

[sobolevn]

We no longer skip Docs and Windows MSI jobs on workflow_trigger but instead they are now always executed on manual runs.

Refs #122336

• Issue: "test" GitHub Action workflow cannot be run manually #122965

[sobolevn]

My manual run: https://github.com/sobolevn/cpython/actions/runs/10366976128

[sobolevn]

One more point to consider: maybe instead we always need to run docs and windows msi jobs on workflow_dispatch: and not skip them?

Basically I propose to think about this change, from:

    - name: Check for docs changes
      if: >-
        github.event_name == 'pull_request'
        && steps.changed-docs-files.outputs.added_modified_renamed != ''
      id: docs-changes
      run: |
        echo "run-docs=true" >> "${GITHUB_OUTPUT}"

to:

    - name: Check for docs changes
      if: >-
        (github.event_name == 'pull_request'
           && steps.changed-docs-files.outputs.added_modified_renamed != '')
        || github.event_name == 'workflow_dispatch'
      id: docs-changes
      run: |
        echo "run-docs=true" >> "${GITHUB_OUTPUT}"

and the same for - name: Check for changes in MSI installer-related files

[sobolevn]

Docs job didn't really work out:

https://github.com/sobolevn/cpython/actions/runs/10368635188/job/28702683326

So, I addapted it.

[sobolevn]

The last version worked: https://github.com/sobolevn/cpython/actions/runs/10368788774/job/28703154687

[sobolevn]

Done, @hugovk! Thanks for your quick and helpful review! 👍

[webknjaz]

Looks like the PR title/description needs updating.

[sobolevn]

Failures are unrelated, GitHub was down. Re-running.

The manual build was succesful: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891

[sobolevn]

This looks complete now! GitHub re-run worked, local manual tests passed: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891

Thanks everyone!

[hugovk]

Thanks!

[miss-islington-app]

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

[bedevere-app]

GH-123008 is a backport of this pull request to the 3.13 branch.

[bedevere-app]

GH-123009 is a backport of this pull request to the 3.12 branch.

[hugovk]

After merging, I tested a manual trigger and looks good: https://github.com/python/cpython/actions/runs/10387198512 👍