Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-118093: Turn some DEOPT_IFs into EXIT_IFs #122998

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Aug 14, 2024

This allows us to stitch new traces onto these side-exits, giving us better handling of polymorphism for attribute loads and calls.

About 1% faster. Stats show a notable (~28%) drop in _DEOPT instructions and moderate increases in call and attribute load uops, as expected.

@brandtbucher brandtbucher added performance Performance or resource usage skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Aug 14, 2024
@brandtbucher brandtbucher self-assigned this Aug 14, 2024
@brandtbucher brandtbucher merged commit f84754b into python:main Aug 14, 2024
61 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit f84754b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1226/builds/2473) and take a look at the build logs.
  4. Check if the failure is related to this commit (f84754b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1226/builds/2473

Failed tests:

  • test_free_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
Note: switching to 'f84754b70506f03bcbf9fb0265e327d05a1a4b51'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at f84754b705 GH-118093: Turn some DEOPT_IFs into EXIT_IFs (GH-122998)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)

make: *** [Makefile:2304: buildbottest] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants