[3.13] gh-118658: Return consistent types from get_un/verified_chain in SSLObject and SSLSocket (GH-118669)
#123082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in `SSLObject` and `SSLSocket` (pythonGH-118669) (cherry picked from commit 8ef358d) Co-authored-by: Mateusz Nowak <nowak.mateusz@hotmail.com> Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
This was referenced Aug 16, 2024
Merged
felixfontein
approved these changes
Aug 17, 2024
sethmlarson
approved these changes
Aug 19, 2024
|
(Anyone looking through this PR wondering why I didn't get Thomas to review it for 3.13, Thomas and I spoke about this on Discord for 3.13 and he already approved and merged the main PR) |
|
@sethmlarson thanks a lot to both of you for getting this into 3.13! :) (And yes, I was wondering about that, I assumed that you probably got an approval via another communication channels... :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 8ef358d)
Co-authored-by: Mateusz Nowak nowak.mateusz@hotmail.com
Co-authored-by: Gregory P. Smith [Google LLC] greg@krypto.org