Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-86673: Harden test_ttk.test_element_create_image #123335

Merged
merged 4 commits into from
Sep 27, 2024
Merged

gh-86673: Harden test_ttk.test_element_create_image #123335

merged 4 commits into from
Sep 27, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 26, 2024 •
edited by bedevere-app bot
Loading

@erlend-aasland erlend-aasland added skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Aug 26, 2024
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Aug 26, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 26, 2024
Closed
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Aug 26, 2024 •
edited
Loading

This is simply @ronaldoussoren's patch from the issue. Adding Serhiy as a reviewer, because of his Tk competence.

@erlend-aasland
Copy link
Contributor Author

We should perhaps add an explanatory comment before eventually landing this.

@erlend-aasland erlend-aasland changed the title gh-86673: Fix test_element_create_image() in test_ttk gh-86673: Harden test_element_create_image() in test_ttk Sep 26, 2024
@erlend-aasland erlend-aasland changed the title gh-86673: Harden test_element_create_image() in test_ttk gh-86673: Harden test_ttk.test_element_create_image Sep 26, 2024
@erlend-aasland erlend-aasland merged commit 08e1bbe into python:main Sep 27, 2024
34 checks passed
@erlend-aasland erlend-aasland deleted the fix-macos-ttk-test branch September 27, 2024 06:21
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@erlend-aasland @serhiy-storchaka @miss-islington
pythongh-86673: Harden test_ttk.test_element_create_image (pythonGH…
74bbe10 
…-123335)

(cherry picked from commit 08e1bbe)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124654 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@erlend-aasland @serhiy-storchaka @miss-islington
pythongh-86673: Harden test_ttk.test_element_create_image (pythonGH…
f50f180 
…-123335)

(cherry picked from commit 08e1bbe)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@erlend-aasland
Copy link
Contributor Author

Thanks, Serhiy and Ronald!

@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124655 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 27, 2024
erlend-aasland pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-86673: Harden test_ttk.test_element_create_image (GH-123335…
4d38254 
…) (#124655)

(cherry picked from commit 08e1bbe)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @erlend-aasland @serhiy-storchaka
[3.13] gh-86673: Harden test_ttk.test_element_create_image (GH-123335…
caaf939 
…) (#124654)

gh-86673: Harden `test_ttk.test_element_create_image` (GH-123335)
(cherry picked from commit 08e1bbe)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @serhiy-storchaka @ronaldoussoren