Skip to content

[3.13] gh-122666: Tests for ast optimizations (GH-122667) #123359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2024
Merged

[3.13] gh-122666: Tests for ast optimizations (GH-122667) #123359

merged 3 commits into from
Aug 27, 2024

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 26, 2024 •
edited by bedevere-app bot
Loading

(cherry picked from commit 9f9b00d)

Co-authored-by: Kirill Podoprigora kirill.bast9@mail.ru
Co-authored-by: Sergey B Kirpichev skirpichev@gmail.com
Co-authored-by: Victor Stinner vstinner@python.org
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

@Eclips4 @skirpichev
@vstinner @JelleZijlstra @miss-islington
pythongh-122666: Tests for ast optimizations (pythonGH-122667)
64c6cc0 
(cherry picked from commit 9f9b00d)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Aug 26, 2024
Merged
@bedevere-app bedevere-app bot mentioned this pull request Aug 26, 2024
Closed
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Aug 26, 2024

cc @Eclips4 the tests are failing because ast.compare didn't exist in 3.13. We'll probably have to add a simple version of compare just in the test; maybe can simply ast.dump() both trees and string compare them.

@Eclips4 Eclips4 self-assigned this Aug 27, 2024
@Eclips4 Eclips4 requested a review from JelleZijlstra August 27, 2024 07:22
vstinner
vstinner approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra JelleZijlstra merged commit 69b104a into python:3.13 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

@Eclips4 Eclips4

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @JelleZijlstra @vstinner @Eclips4