Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] gh-121285: Remove backtracking when parsing tarfile headers (GH-121286) #123542

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[3.13] gh-121285: Remove backtracking when parsing tarfile headers (GH-121286) #123542

merged 1 commit into from
Sep 2, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 31, 2024 •
edited by bedevere-app bot
Loading

  • Remove backtracking when parsing tarfile headers
  • Rewrite PAX header parsing to be stricter
  • Optimize parsing of GNU extended sparse headers v0.0

(cherry picked from commit 34ddb64)

Co-authored-by: Seth Michael Larson seth@python.org
Co-authored-by: Kirill Podoprigora kirill.bast9@mail.ru
Co-authored-by: Gregory P. Smith greg@krypto.org

@sethmlarson @Eclips4
@gpshead @miss-islington
pythongh-121285: Remove backtracking when parsing tarfile headers (py…
c47341f 
…thonGH-121286)

* Remove backtracking when parsing tarfile headers
* Rewrite PAX header parsing to be stricter
* Optimize parsing of GNU extended sparse headers v0.0

(cherry picked from commit 34ddb64)

Co-authored-by: Seth Michael Larson <seth@python.org>
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app bedevere-app bot mentioned this pull request Aug 31, 2024
Merged
@bedevere-app bedevere-app bot added the type-security A security issue label Aug 31, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 31, 2024
Closed
@Yhg1s Yhg1s merged commit ed3a49e into python:3.13 Sep 2, 2024
40 checks passed
pullenmil
pullenmil reviewed Oct 8, 2024
View reviewed changes
Copy link

@pullenmil pullenmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will compress your bulk put it in a hidden lib file and wont have to ask to keep. will keep out syntax error

Lib/tarfile.py
@@ -846,6 +846,9 @@ def data_filter(member, dest_path):
# Sentinel for replace() defaults, meaning "don't change the attribute"
_KEEP = object()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_bulk=object()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullenmil pullenmil pullenmil left review comments

@gpshead gpshead gpshead approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

@Yhg1s Yhg1s

Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @gpshead @pullenmil @Yhg1s @sethmlarson