Skip to content

Conversation

@Glyphack
Copy link
Contributor

@Glyphack Glyphack commented Sep 2, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Sep 2, 2024
@Glyphack Glyphack marked this pull request as ready for review September 2, 2024 18:01
@Glyphack Glyphack force-pushed the document-exclamation-token branch from d3891ca to c7372e6 Compare September 2, 2024 19:39
@lysnikolaou
Copy link
Member

Hmm, now that I look at this again, I'm not sure whether ! qualifies as an operator. It might be better off being in the delimeters list? @pablogsal What do you think?

@pablogsal
Copy link
Member

Hmm, now that I look at this again, I'm not sure whether ! qualifies as an operator. It might be better off being in the delimeters list? @pablogsal What do you think?

It's certainly not an operator. I would include in the delimiter list for sure. It's very similar to the ":" in the sense that it separates two parts, it doesn't apply to any or both of them

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lysnikolaou lysnikolaou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 3, 2024
@lysnikolaou lysnikolaou merged commit 68fe575 into python:main Sep 3, 2024
@miss-islington-app
Copy link

Thanks @Glyphack for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2024
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 3, 2024

GH-123637 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2024
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 3, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 3, 2024

GH-123638 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 3, 2024
@Glyphack Glyphack deleted the document-exclamation-token branch September 3, 2024 14:50
lysnikolaou pushed a commit that referenced this pull request Sep 3, 2024
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
lysnikolaou pushed a commit that referenced this pull request Sep 3, 2024
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants