-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120619: Tier 2 partial evaluation pass foundations #123652
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
requested review from
markshannon and
erlend-aasland
as code owners
September 3, 2024 19:38
No slowdown which is great to see. Since this pass currently does no optimizations at all https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240904-3.14.0a0-a6bc1a0-JIT |
Have a better plan. PR up soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up a tier 2 partial evaluation pass' foundations. It does the following:
As a litmus test, it does simple dead store elimination by tracking locals. For example, the code
x = x
is now optimized to a nop.This PR does not yet have full shadow stack reconstruction on side-exits. Because that first requires a principled design of side-exits. Thus after this PR lands, that needs to be worked on.