Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123718: Fix implicit declaration of 'explicit_memset' for NetBSD 10.0 in Lib_Memzero0.c #123719

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Sep 4, 2024

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

vstinner commented Sep 5, 2024

You need to run make regen-all: https://github.com/python/cpython/actions/runs/10711299168/job/29699711913?pr=123719

@vstinner
Copy link
Member

vstinner commented Sep 5, 2024

Also, this file is just a copy of https://github.com/cryspen/hacl-packages/blob/main/src/Lib_Memzero0.c

Please file also an issue to this source repository.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, your Programs/test_frozenmain.h change is invalid, and I was wrong: you should run make regen-sbom. Sorry about that.

@vstinner vstinner enabled auto-merge (squash) September 5, 2024 23:51
@vstinner vstinner merged commit f8f7500 into python:main Sep 6, 2024
37 checks passed
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Sep 9, 2024
@miss-islington-app
Copy link

Thanks @furkanonder for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @furkanonder and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f8f7500168c94330e094aebfa38798d949466328 3.13

@vstinner
Copy link
Member

vstinner commented Sep 9, 2024

@furkanonder: Do you want to backport manually the change to 3.13?

@vstinner
Copy link
Member

vstinner commented Sep 9, 2024

Nevermind, Modules/_hacl/Lib_Memzero0.c doesn't exist in the 3.13 branch.

@vstinner vstinner removed the needs backport to 3.13 bugs and security fixes label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants