-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-123718: Fix implicit declaration of 'explicit_memset' for NetBSD 10.0 in Lib_Memzero0.c #123719
Conversation
furkanonder
commented
Sep 4, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Build error: implicit declaration of 'explicit_memset' in NetBSD #123718
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You need to run |
Also, this file is just a copy of https://github.com/cryspen/hacl-packages/blob/main/src/Lib_Memzero0.c Please file also an issue to this source repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, your Programs/test_frozenmain.h
change is invalid, and I was wrong: you should run make regen-sbom
. Sorry about that.
Thanks @furkanonder for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @furkanonder and @vstinner, I could not cleanly backport this to
|
@furkanonder: Do you want to backport manually the change to 3.13? |
Nevermind, |