gh-123748: Disable HACL SIMD256 on universal builds. #123927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
requested review from
erlend-aasland and
corona10
as code owners
|
I agree with the subsequent discussion on the issue that using some sort of compile-time |
|
Ok - closing on the basis that a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native HACL implementation added in #119316 compiles fine on single architecture x86_64 and ARM64 macOS builds, but failed when compiled on universal2 builds. This is because the autoconf detection is based on the existence of the
-mavx2compiler flag; this flag is legal in universal builds (because the x86_64 compilation path supports the flag), but this then requires symbols that aren't available on ARM64 builds. A standalone ARM64 build disables this feature.This PR modifies the autoconf check so that if
-mavx2support is detected and the build is universal2, the autoconf feature isn't enabled.