GH-103219: Fix optional args incorrectly being processed as required args #123931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savannahostrowski
added
tests
savannahostrowski
changed the title
|
See also #124306 which fixes the bug in other way. It actually fixes several bugs, so I think that it is more correct way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a pretty old bug where optional args were incorrectly marked as required and adds a corresponding test case. We now more thoroughly check to see that an arg is 1) required, 2) has no default value, and 3)
nargsis not set to*or?before adding it to the list of required args.It looks like this bug at least dates back to 3.9, but since those releases are just for security fixes at this point, I've marked this for backport to 3.12 and 3.13.