Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124457: Remove coverity from CPython repo #124460

Merged
merged 1 commit into from
Sep 27, 2024
Merged

gh-124457: Remove coverity from CPython repo #124460

merged 1 commit into from
Sep 27, 2024

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Sep 24, 2024 •
edited by bedevere-app bot
Loading

Remove coverity from CPython Repo.

There are still some mentions about coverity in the history and changelog for v 2.5. I kept those in there.

@bedevere-app bedevere-app bot mentioned this pull request Sep 24, 2024
Closed
Mariatta
Mariatta commented Sep 24, 2024
View reviewed changes
Misc/NEWS.d/next/Documentation/2024-09-24-11-52-36.gh-issue-124457.yrCjSV.rst
@@ -0,0 +1,2 @@
Remove coverity scan from the CPython repo. It has not been used since 2020
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if a Misc News entry is needed, and also I wasn't sure which section should it be.
I chose the "Documentation" section here.

@Mariatta Mariatta mentioned this pull request Sep 24, 2024
Merged
@vstinner
Copy link
Member

Please keep it. We are using Coverity at Red Hat. cc @stratakis

@stratakis
Copy link
Contributor

While we use coverity at Red Hat, it's usually done on specific time frames using OpenScanHub. And we don't utilize the coverity scan model file. So overall I believe the removal is fine. Maybe in the future a nice project would be to introduce coverity scanning through either some service, the buildbots or github actions.

@vstinner
Copy link
Member

And we don't utilize the coverity scan model file.

Oh, I didn't know that.

vstinner
vstinner approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's remove it. It's easy to add it again if someone decides to use it again.

@AA-Turner AA-Turner changed the title gh-124457: Remove coverity from CPython repo. gh-124457: Remove coverity from CPython repo Sep 26, 2024
@Mariatta Mariatta merged commit 6cba6e1 into python:main Sep 27, 2024
28 checks passed
@Mariatta Mariatta deleted the remove-coverity branch September 27, 2024 20:42
@Mariatta
Copy link
Member Author

Do I need to backport this?

@Mariatta
Copy link
Member Author

And thanks for the reviews!

@vstinner
Copy link
Member

Do I need to backport this?

I don't think so.

@Mariatta
Copy link
Member Author

Thanks, in this case I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mariatta @vstinner @stratakis @AA-Turner