Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve venv docs #124540

Merged
merged 1 commit into from
Sep 28, 2024
Merged

docs: improve venv docs #124540

merged 1 commit into from
Sep 28, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Sep 25, 2024

  • Move "versionchanged" notes that apply to the whole class to the
    end of the class docs
  • Remove or move notes next to the method list that apply to individual
    methods.
  • Mark up parameters using the appropriate syntax
  • Do not capitalize "boolean"
  • Shorten some text

📚 Documentation preview 📚: https://cpython-previews--124540.org.readthedocs.build/

- Move "versionchanged" notes that apply to the whole class to the
  end of the class docs
- Remove or move notes next to the method list that apply to individual
  methods.
- Mark up parameters using the appropriate syntax
- Do not capitalize "boolean"
- Shorten some text
@@ -168,31 +168,31 @@ creation according to their needs, the :class:`EnvBuilder` class.
The :class:`EnvBuilder` class accepts the following keyword arguments on
instantiation:

* ``system_site_packages`` -- a Boolean value indicating that the system Python
* *system_site_packages* -- a boolean value indicating that the system Python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also consider using a parameter list for this (which would render similar to https://docs.python.org/3/library/sqlite3.html#sqlite3.connect). But it's okay if you want to declare that out of scope for this PR :-)

@AlexWaygood AlexWaygood added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 25, 2024
@JelleZijlstra JelleZijlstra merged commit c976d78 into python:main Sep 28, 2024
32 checks passed
@miss-islington-app
Copy link

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the venvdocs branch September 28, 2024 12:50
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 28, 2024
- Move "versionchanged" notes that apply to the whole class to the
  end of the class docs
- Remove or move notes next to the method list that apply to individual
  methods.
- Mark up parameters using the appropriate syntax
- Do not capitalize "boolean"
- Shorten some text
(cherry picked from commit c976d78)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@miss-islington-app
Copy link

Sorry, @JelleZijlstra, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c976d789a98047ae7ddec6d13c9ea7086d9fa3f9 3.12

@bedevere-app
Copy link

bedevere-app bot commented Sep 28, 2024

GH-124727 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 28, 2024
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request Sep 28, 2024
- Move "versionchanged" notes that apply to the whole class to the
  end of the class docs
- Remove or move notes next to the method list that apply to individual
  methods.
- Mark up parameters using the appropriate syntax
- Do not capitalize "boolean"
- Shorten some text
(cherry picked from commit c976d78)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 28, 2024

GH-124728 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 28, 2024
JelleZijlstra added a commit that referenced this pull request Sep 28, 2024
- Move "versionchanged" notes that apply to the whole class to the
  end of the class docs
- Remove or move notes next to the method list that apply to individual
  methods.
- Mark up parameters using the appropriate syntax
- Do not capitalize "boolean"
- Shorten some text
(cherry picked from commit c976d78)
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
docs: improve venv docs (GH-124540)

- Move "versionchanged" notes that apply to the whole class to the
  end of the class docs
- Remove or move notes next to the method list that apply to individual
  methods.
- Mark up parameters using the appropriate syntax
- Do not capitalize "boolean"
- Shorten some text
(cherry picked from commit c976d78)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants