Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-124547: Clear instance dictionary if memory error occurs during object dealloc #124627

Merged
merged 2 commits into from
Sep 27, 2024
Merged

GH-124547: Clear instance dictionary if memory error occurs during object dealloc #124627

merged 2 commits into from
Sep 27, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Sep 26, 2024 •
edited by bedevere-app bot
Loading

If a memory error occurs when copying values into the dict during object deallocation: clear the dict, so that the dict is at least a valid object.

@bedevere-app bedevere-app bot mentioned this pull request Sep 26, 2024
Open
@markshannon markshannon added the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
DinoV
DinoV approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markshannon markshannon merged commit 0e21cc6 into python:main Sep 27, 2024
40 checks passed
@miss-islington-app
Copy link

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@markshannon @miss-islington
pythonGH-124547: Clear instance dictionary if memory error occurs dur…
0a7c944 
…ing object dealloc (pythonGH-124627)

(cherry picked from commit 0e21cc6)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124714 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @markshannon
[3.13] GH-124547: Clear instance dictionary if memory error occurs du…
80de976 
…ring object dealloc (GH-124627) (#124714)

GH-124547: Clear instance dictionary if memory error occurs during object dealloc (GH-124627)
(cherry picked from commit 0e21cc6)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@mpage mpage mentioned this pull request Sep 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DinoV DinoV DinoV approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @DinoV