[3.13] gh-124785: alternative interned string clear fix #124796
Conversation
…rned strings. (pythongh-124646)" This reverts commit dc09a0c.
The pythonGH-124646 fix has the issue that it breaks the trace-refs debug build. This is a simpler fix that avoids the use-after-free crashes by just leaking immortal interned strings allocated by legacy subinterpreters.
AA-Turner
changed the title
|
Since this is a rollback of the original fix plus a new, debatably dodgy fix on top, can we just do a regular rollback of #124648 first? I think we need more time for the proper fix and I'd rather release 3.13 (and 3.12, really) with known issues than introduce wholly new ones. |
|
You should rollback GH-124648, it was not as safe a change as I thought it was. I thought it only kicks into action of you are using "basic single-phase init" extensions and at that point you are already on shaky ground. However it actually kicks in if your sub-interpreter is allowed to use those extensions, i.e With GH-124648 rolled back, you can make a separate decision if you want to merge this PR into a RC. It fixes a use-after-free segfault bug. However, those bugs only get triggered if you are on the shaky ground as explained above (embedding case with legacy sub-interpreters). So, I think you would be well justified to say you don't want to merge this given we are already into RC2. If the ABI change is a problem, I think it can be re-worked to avoid that. Then it could go into 3.13.1 as just a regular bugfix. |
The gh-124646 fix has the issue that it breaks the trace-refs debug build. This is a simpler fix that avoids the use-after-free crashes by just leaking immortal interned strings allocated by legacy sub-interpreters.