gh-124295: Add translation tests for argparse

[tomasr8]

This uses Tools/i18n/pygettext.py to extract all translatable messages from argparse.py. The messages are kept in a snapshot file in the test folder. The test extracts the current messages and compares them against this snapshot.

The snapshot can be updated using ./python Lib/test/test_argparse/test_translations.py --snapshot-update.

There is currently no way to read a PO file using the stdlib (gettext only reads MO files, maybe it should be able to do both?) so I just use a simple regex to get the msgids out of the PO file.

Feedback welcome!

• Issue: Add translation tests for argparse #124295

[serhiy-storchaka]

LGTM. Thank you, @tomasr8.

Since argparse is currently actively fixed, there are some conflicts. After fixing them I'll merge this PR.

[serhiy-storchaka]

I will wait for the 3.13 release before merging this PR because it will conflict with many backports waiting for 3.13. It would be easier to resolve conflicts in this PR (just move test_argparse.py) than in other PRs which modify the part of the file.

[tomasr8]

I will wait for the 3.13 release before merging this PR because it will conflict with many backports waiting for 3.13. It would be easier to resolve conflicts in this PR (just move test_argparse.py) than in other PRs which modify the part of the file.

Ok! Let me know if I can help with anything :)

[serhiy-storchaka]

Don't worry, I'll merge this PR when the time comes.

[tomasr8]

Don't worry, I'll merge this PR when the time comes.

Github was complaining about some merge conflicts so I just wanted to update the branch ;)

[tomasr8]

On Serhiy's suggestion, I moved the translation data into a separate folder and merged the new tests with the existing ones to avoid turning the tests into a package.

[miss-islington-app]

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0922a4ae0d2803e3a4e9f3d2ccd217364cfd700e 3.13

[miss-islington-app]

Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0922a4ae0d2803e3a4e9f3d2ccd217364cfd700e 3.12

[bedevere-app]

GH-126046 is a backport of this pull request to the 3.13 branch.

[tomasr8]

There seems to be a buildbot failure related to this PR: https://buildbot.python.org/#/builders/1244/builds/3363
I think it's because scripts are not always included in python installations. We'll probably need to guard the test with skip_if_missing.

Edit: maybe something like this?

  @requires_subprocess()
+ @requires_tool('i18n')
  class TestTranslations(unittest.TestCase):

with this helper function in test_tools?

def requires_tool(tool=None):
    exists = True
    try:
        skip_if_missing(tool)
    except unittest.SkipTest:
        exists = False
    return unittest.skipUnless(exists, f'{tool} not available')

[serhiy-storchaka]

Do you mind to create a PR? I paused backporting.

Simply call skip_if_missing() in the test. Or in setUpClass() if there were several tests.

[tomasr8]

Do you mind to create a PR? I paused backporting.

Simply call skip_if_missing() in the test. Or in setUpClass() if there were several tests.

On it :)

[tomasr8]

PR is here: #126051