Skip to content

gh-85935: Improve tests for invalid arguments in test_argparse #124891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 2, 2024

@serhiy-storchaka serhiy-storchaka force-pushed the test-argparse-invalid-argument-constructor branch from 6a81c3a to c5becc9 Compare October 2, 2024 12:55
@serhiy-storchaka serhiy-storchaka merged commit 2c050d4 into python:main Oct 2, 2024
32 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test-argparse-invalid-argument-constructor branch October 2, 2024 13:28
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2c050d4bc28bffd2990b5a0bd03fb6fc56b13656 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2024
…ythonGH-124891)

Check also specific error messages.
(cherry picked from commit 2c050d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2024

GH-124898 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 2, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2024
…gparse (pythonGH-124891)

Check also specific error messages.
(cherry picked from commit 2c050d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2024

GH-124901 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 2, 2024
serhiy-storchaka added a commit that referenced this pull request Oct 2, 2024
…GH-124891) (GH-124898)

Check also specific error messages.
(cherry picked from commit 2c050d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Oct 8, 2024
…GH-124891) (GH-124901)

Check also specific error messages.
(cherry picked from commit 2c050d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant